matthiasblaesing commented on a change in pull request #2194:
URL: https://github.com/apache/netbeans/pull/2194#discussion_r444476553
##########
File path:
profiler/lib.profiler/src/org/netbeans/lib/profiler/results/BaseCallGraphBuilder.java
##########
@@ -42,7 +42,7 @@
//~ Instance fields
----------------------------------------------------------------------------------------------------------
- protected List/*<Runnable>*/ afterBatchCommands = new ArrayList<>();
+ protected List<Runnable> afterBatchCommands = new ArrayList<>();
Review comment:
This is a friend API.
##########
File path:
profiler/lib.profiler/src/org/netbeans/lib/profiler/heap/ClassDumpSegment.java
##########
@@ -202,12 +202,12 @@ void addInstanceSize(ClassDump cls, int tag, long
instanceOffset) {
}
}
- synchronized List /*<JavaClass>*/ createClassCollection() {
+ synchronized List/*<JavaClass>*/ createClassCollection() {
Review comment:
This is package private - I would not consider this API, so could be
made generic and then the callsite of this function could be generified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
