matthiasblaesing commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r487429590
##########
File path:
ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " +
factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the
target of this PR.
##########
File path:
ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " +
factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the
target of this PR.
##########
File path:
ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " +
factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the
target of this PR.
##########
File path:
ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " +
factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the
target of this PR.
##########
File path:
ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " +
factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the
target of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
