matthiasblaesing commented on pull request #2491: URL: https://github.com/apache/netbeans/pull/2491#issuecomment-748664582
The testing reads good. Reviewing is difficult, because there are to many commits to review per commit and to many changes in general to review by file. I suggest to do the cleanup you suggested and squash the changes. If possible split cleanup (@Override, loggers) and actually function changes into separate commits. After that it should be easier to review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
