pepness commented on a change in pull request #2491:
URL: https://github.com/apache/netbeans/pull/2491#discussion_r562300114
##########
File path:
enterprise/j2ee.clientproject/src/org/netbeans/modules/j2ee/clientproject/api/AppClientProjectGenerator.java
##########
@@ -544,9 +563,7 @@ private static AntProjectHelper setupProject(FileObject
dirFO, String name,
String sourceLevel = v.toString();
// #89131: these levels are not actually distinct from 1.5.
// #181215: JDK 6 should be the default source/binary format for Java
EE 6 projects
- if (sourceLevel.equals("1.7")) {
- sourceLevel = "1.6";
- }
+ // #181215: Not neccessary anymore because NetBeans should run on
minimum JDK 8
Review comment:
After a more detailed testing to these validations, the methods were
these validations reside are called every time independently of the selected
profile. The `sourceLevel` variable is equal to the Java version that NetBeans
is running.
> JavaPlatform defaultPlatform =
JavaPlatformManager.getDefault().getDefaultPlatform();
> SpecificationVersion v = defaultPlatform.getSpecification().getVersion();
> String sourceLevel = v.toString();
In a new commit I added some missing validation that sets the correct target
source level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
