sdedic commented on a change in pull request #2685: URL: https://github.com/apache/netbeans/pull/2685#discussion_r560873595
########## File path: java/java.lsp.server/nbcode/branding/modules/org-openide-loaders.jar/org/netbeans/modules/openide/loaders/Bundle.properties ########## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# yes/no/ask +ASK_OnSaving=no +# yes/no/ask +ASK_OnClosing=no Review comment: Q: shouldn't be there some dependency on loaders >= 1.80 ? ########## File path: platform/openide.loaders/arch.xml ########## @@ -542,6 +542,21 @@ for more information about this. underlaying <a href="@TOP@/architecture-summary.html#script">scripting and templating engines</a>. </api> + + <api name="ASK_OnSaving" group="branding" type="export" category="stable"> Review comment: Isuggest to establish some policy or naming convention on these functional resource bundle keys. Maybe a separate Bundle should be always used, but either the bundle or the API keys should be named so that everyone knows that moving the keys to another bundle, renaming the keys, or change of usage is a BIG no-no. ########## File path: platform/openide.loaders/src/org/openide/text/DataEditorSupport.java ########## @@ -1353,19 +1331,8 @@ public void run() throws IOException { try { des.superSaveDoc(); } catch (UserQuestionException ex) { - if (GraphicsEnvironment.isHeadless()) { Review comment: Note that this code was released with 12.2; IMHO in headless environment the code should default to 'yes' setting to remain compatible. Otherwise declare an incompatible change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
