JaroslavTulach commented on a change in pull request #2685:
URL: https://github.com/apache/netbeans/pull/2685#discussion_r560895910



##########
File path: platform/openide.loaders/arch.xml
##########
@@ -542,6 +542,21 @@ for more information about this.
         underlaying <a href="@TOP@/architecture-summary.html#script">scripting 
and templating
         engines</a>.
     </api>
+
+    <api name="ASK_OnSaving" group="branding" type="export" category="stable">

Review comment:
       Looking at [list of branding 
APIs](https://bits.netbeans.org/dev/javadoc/branding.html), it seems there used 
to be some convention. For example the 
`org.netbeans.core.netigso.FRAMEWORK_START_LEVEL` key & similar seem to spell 
out the package name of the bundle first and then some further info.
   
   I can follow that convention in this PR too. Fixing others may be better for 
some another PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to