jtulach commented on a change in pull request #2761:
URL: https://github.com/apache/netbeans/pull/2761#discussion_r577351757
##########
File path: platform/o.n.bootstrap/src/org/netbeans/StandardModuleData.java
##########
@@ -78,7 +80,12 @@ public StandardModuleData(Manifest mf, StandardModule
forModule) throws InvalidE
if (classPath != null) {
StringTokenizer tok = new StringTokenizer(classPath);
while (tok.hasMoreTokens()) {
- String ext = tok.nextToken().replace("%20", " "); // NOI18N
+ String ext;
+ try {
+ ext = URLDecoder.decode(tok.nextToken(), "UTF-8");
+ } catch (UnsupportedEncodingException ex) {
+ throw new IllegalStateException(ex);
+ }
File extfile;
if (ext.equals("${java.home}/lib/ext/jfxrt.jar")) { // NOI18N
Review comment:
Yes, the `${java.home}` string is totally artificial. I have chosen it
as it had no meaning for `javac` (in JDK8, who could expect JDK11 starts to
recognize URLs in `Class-Path` attribute!).
There already was some URI-like processing (replacing `%20` by ` `) and
using `URLDecoder` (not available on JDK7 at the time of writing this code) can
be seen as a "proper fix" of processing the URI component.
Right, the JDK7 specific code can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
