matthiasblaesing commented on pull request #2761: URL: https://github.com/apache/netbeans/pull/2761#issuecomment-782874386
This looks interesting and an improvement. I have the following remarks/questions: - There are adjustments to `javac.target` but not `javac.source`. This I don't understand - is the intention here to allow javac to generate more modern code, that uses features only present on Java 8+, but not suffer from code incompatibilites by using old source parser/behavior? - Why is `javac.default.target` overriden to `1.8`, instead of relying on the default behavior in `nbbuild/templates/common.xml` - there the default target is initialized to `javac.source`, which sounds sane to me? - I noticed some changes to `build.xml` files, which add `release="8" target="1.8" ` - on JDK 9+ target is not necessary, as release substitutes it. I would expect target to default to 8 on JDK 8, so this feels like a duplicate. The bump of the baseline linux distribution for unittests looks sane to me. Thank you for working on this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
