sdedic commented on a change in pull request #2756:
URL: https://github.com/apache/netbeans/pull/2756#discussion_r577672208
##########
File path: enterprise/websvc.manager/manifest.mf
##########
@@ -3,5 +3,5 @@ AutoUpdate-Show-In-Client: false
OpenIDE-Module: org.netbeans.modules.websvc.manager
OpenIDE-Module-Localizing-Bundle:
org/netbeans/modules/websvc/manager/Bundle.properties
OpenIDE-Module-Install:
org/netbeans/modules/websvc/manager/WebServiceModuleInstaller.class
-OpenIDE-Module-Specification-Version: 1.39
+OpenIDE-Module-Specification-Version: 1.40
Review comment:
Is this a functional change - new or altered behaviour ? All changed
classes are in impl package not exposed outside the module: no spec version
change is needed IMHO.
##########
File path: java/dbschema/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.dbschema/1
-OpenIDE-Module-Implementation-Version: 4
+OpenIDE-Module-Implementation-Version: 5
Review comment:
Here you probably want to increment `specification-version` (see
`project.properties`). You're changing `friend-public` API in a
binary-incompatible way (but that should not matter as all friends are
recompiled in the tree - right @JaroslavTulach ?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
