JaroslavTulach commented on a change in pull request #2756:
URL: https://github.com/apache/netbeans/pull/2756#discussion_r578993565
##########
File path: java/dbschema/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.dbschema/1
-OpenIDE-Module-Implementation-Version: 4
+OpenIDE-Module-Implementation-Version: 5
Review comment:
Thanks for CCing me, Sváťo!
I see that the [signature
test](https://travis-ci.com/github/apache/netbeans/jobs/482358349) failed with:
```
Class org.netbeans.modules.dbschema.jdbcimpl.IndexElementImpl
"E1.2 - API type removed" : method protected void
org.netbeans.modules.dbschema.jdbcimpl.IndexElementImpl.initColumns(java.util.LinkedList)
Class org.netbeans.modules.dbschema.jdbcimpl.SchemaElementImpl
"E1.2 - API type removed" : method public void
org.netbeans.modules.dbschema.jdbcimpl.SchemaElementImpl.initTables(org.netbeans.modules.dbschema.jdbcimpl.ConnectionProvider,java.util.LinkedList,java.util.LinkedList)
```
I suggest to not change any public signature incompatibly. While...
> changing friend-public API in a binary-incompatible way (but that should
not matter as all friends are recompiled in the tree
...is possible. You'd have to increase dependencies of all friend modules.
It is easier to keep `LinkedList` where it was. Even I agree with [code against
interfaces not
implementation](http://wiki.apidesign.org/wiki/Code_Against_Interfaces%2C_Not_Implementations)
advice, I value backward compatibility more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
