ebresie commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r598689578
##########
File path:
ide/db.sql.editor/src/org/netbeans/modules/db/sql/editor/completion/SQLCompletionQuery.java
##########
@@ -120,23 +120,37 @@ public void query(SQLCompletionResultSet resultSet,
SQLCompletionEnv newEnv) {
private void doQuery(final SQLCompletionEnv newEnv) {
try {
+ // DB Connection available
+ if (dbconn != null) {
Review comment:
Not sure I completely understand (trying to learn here). What might
cause that to be changed to null? Is the suggestion in some other context
(maybe another thread or file window), the dbconn is set (or unset) in some
other way?
The dbconn is set as part of the SQLCompletionQuery constructor which is
used during the "SQLCompletionProvider.createTask" with a AsyncCompletionTask
constructor, using a dbconn from that context. I believe in those context it
may be creating a new instance, but not 100% sure here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
