matthiasblaesing commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r598881943
##########
File path:
ide/db.sql.editor/src/org/netbeans/modules/db/sql/analyzer/SQLStatementAnalyzer.java
##########
@@ -239,6 +239,8 @@ protected QualIdent parseIdentifier() {
}
protected String getUnquotedIdentifier() {
+ if (quoter == null)
+ return "";
Review comment:
It depends. I was the one, that pointed out, that it is highly
problematic to try to create a completion without a corresponding connection.
There is Standard SQL, so you can build a quoter based on that, but then you
also need to guess what is considered a keyword an d what not.
Maybe there is a different approach possible: Don't try to be clever and
use a parser, but use keyword based completion. You could have a look at
phpmyadmin completion how it is handled there. I doubt, that they went the way
of a full parser in JS, but most probably complete based on keyword prefix
matching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
