hectorespert commented on pull request #2744: URL: https://github.com/apache/netbeans/pull/2744#issuecomment-812887631
> A step in the good direction, though if we are adding new LAF keys, probably shall add constants for it in LFCustoms. I added the new constants in LFCustoms. > And by introducing that it would be good to check if all supported LAF-s are providing defaults for the new key. New keys are only used by GTK theme, I would like to fix the problem with that theme before start to modify the other themes. > A sidenote: It would be really great if you could detect somehow when the GTK skin is set to dark, if it does, it would be great at least add the `"nb.dark.theme"` to true. A GTK configuration property to detect that is available: https://developer.gnome.org/gtk3/3.8/GtkSettings.html#GtkSettings--gtk-application-prefer-dark-theme -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
