lkishalmi commented on a change in pull request #2744:
URL: https://github.com/apache/netbeans/pull/2744#discussion_r673940750
##########
File path: platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/LFCustoms.java
##########
@@ -423,4 +423,11 @@ private void disposeValues (Object[] arr) {
public static final String PROGRESS_CANCEL_BUTTON_ICON =
"nb.progress.cancel.icon";
public static final String PROGRESS_CANCEL_BUTTON_ROLLOVER_ICON =
"nb.progress.cancel.icon.mouseover";
public static final String PROGRESS_CANCEL_BUTTON_PRESSED_ICON =
"nb.progress.cancel.icon.pressed";
+
+ /**
+ * Keys used by the options dialog module.
+ */
+ protected static final String OPTIONS_USE_UI_DEFAULT_COLORS =
"Nb.options.useUIDefaultsColors";
Review comment:
Why protected instead of public?
"Nb" or "nb"? Yes I've seen both prefixes, however it would be good to stick
with "nb.options"
##########
File path:
platform/options.api/src/org/netbeans/modules/options/OptionsPanel.java
##########
@@ -877,7 +869,7 @@ private void addCategoryButtons () {
private CategoryButton addButton (CategoryModel.Category category) {
int index = buttons.size ();
- CategoryButton button = isNimbus || isGTK
+ CategoryButton button =
UIManager.getBoolean("Nb.options.categories.button.useNimbusCategoryButton")
//NOI18N
Review comment:
Would be nicer to reintroduce the same constants as in LFCustoms at the
top of the file again (now it can be not public)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
