eirikbakke commented on pull request #2934: URL: https://github.com/apache/netbeans/pull/2934#issuecomment-832918875
I think it's a bigger issue that could be addressed and discussed separately. To act as a canary, and not just a cause of intermittent bugs for some developers (who may or may not report the problem, or may even just give up), problems like these would need to be triggered as part of the automated Windows build on Travis. In fact I'm curious why it doesn't trigger in the Travis Windows builds. I suspect someone explicitly set UTF-8 as the OS-level encoding on the Windows CI images. That might well be a good idea, except then the build does not reproduce problems that occurs for Windows developers who do not change the default encoding on their machines. One could argue that the Travis build should be explicitly set to Windows-1252, to match Windows developers' typical configuration. This would rightly generate some debate, though... So I'd prefer to keep the patch as is for now, but I wouldn't be opposed to adding back a canary later if the Travis builds are adjusted so that these kinds of bugs actually cause failures. (Also, by the way, still a big thank you to @jglick for the original unrelated patch that was coincidentally involved here. It's been solving a lot of Compile-on-Save problems in my project.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
