matthiasblaesing commented on pull request #2934: URL: https://github.com/apache/netbeans/pull/2934#issuecomment-846379231
What I wanted to say with my previous comments, was that according to your test the change to `nbbuild/javadoctools/build.xml` is enough to fix the issue. The changes to `java/java.source.base/arch.xml` are therefore not necessary and not having them, lets the file act as a canary for the issue. I have no strong feelings here. If you want to change it, it is ok, but I (and also @vieiro) would prefer to keep the file as before this PR. So in any case, the fix to `nbbuild/javadoctools/build.xml` should go in soon, with or without the change to `java/java.source.base/arch.xml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
