JaroslavTulach commented on a change in pull request #2969:
URL: https://github.com/apache/netbeans/pull/2969#discussion_r640345032
##########
File path: extide/gradle/arch.xml
##########
@@ -268,6 +268,13 @@ publishPlugins</args>
</actions>
</pre>
</api>
+ <api category="devel" group="java.io.File"
name="nb-actions-config.xml" type="export">
+ <p>
+ An extension of <a
href="#nb-actions-config.xml">nb-actions.config</a> is a per-Configuration
action mapping.
Review comment:
I convinced Laszslo in the past to not expose `nbactions*.xml` files and
rather encode the actions into `build.properties` file. The introduciton of
`nb-actions-config.xml` goes against that decision. It is OK, if you and Laszlo
are OK with that. I just have to mention it.
##########
File path:
extide/gradle/src/org/netbeans/modules/gradle/execute/GradleExecAccessor.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.gradle.execute;
+
+import java.util.Collections;
+import java.util.Map;
+import org.netbeans.modules.gradle.api.execute.GradleExecConfiguration;
+import org.openide.util.Exceptions;
+import org.openide.util.NbBundle;
+
+/**
+ * Accessor to manipulate {@link GradleExecConfiguration} in ways not exposed
in the API.
+ * @author sdedic
+ */
+public abstract class GradleExecAccessor {
Review comment:
Accessor! Every good API needs an accessor!
##########
File path:
platform/openide.filesystems/src/org/openide/filesystems/FileUtil.java
##########
@@ -2337,6 +2341,29 @@ private static boolean isArchiveFileImpl(final URL url,
final boolean strict) {
}
return archiveRootProviderCache;
}
+
+ /**
+ * Hardcoded offending filename characters. Windows are more picky than
Unixes; relying
+ * on just the current host OS will limit file portability when shared
through VCS.
+ */
+ private static final Pattern ILLEGAL_FILENAME_CHARACTERS =
Pattern.compile("[\\/:\"*?<>|]");
+
+ /**
+ * Determines whether the string forms a valid filename (without a path
component).
+ * @param fileName candidate string
+ * @return true, if the string can be used to name a file.
+ */
Review comment:
This is an API change and it comes with no versioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
