eirikbakke commented on pull request #2967:
URL: https://github.com/apache/netbeans/pull/2967#issuecomment-880178164
I made the following changes in a force push:
```
diff --git
a/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/plaf/Windows8VectorTabControlIcon.java
b/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/plaf/Windows8VectorTabControlIcon.java
index 7d1465a..a7131f7 100644
---
a/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/plaf/Windows8VectorTabControlIcon.java
+++
b/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/plaf/Windows8VectorTabControlIcon.java
@@ -43,7 +43,7 @@ import javax.swing.Icon;
* @author Eirik Bakke
*/
@SuppressWarnings("serial")
-public final class Windows8VectorTabControlIcon extends VectorIcon {
+final class Windows8VectorTabControlIcon extends VectorIcon {
private static final Map<Entry<Integer,Integer>,Icon> INSTANCES =
populateInstances();
private final int buttonId;
private final int buttonState;
@@ -118,10 +118,14 @@ public final class Windows8VectorTabControlIcon
extends VectorIcon {
bgColor = closeColor != null ? closeColor : new Color(57,
100, 178, 255);
fgColor = Color.WHITE;
} else if (buttonState == TabControlButton.STATE_ROLLOVER) {
- bgColor = closeColor != null ? closeColor
- // Grey (via transparent black to work well on any
background).
- : new Color(0, 0, 0, 70);
- fgColor = Color.WHITE;
+ if (closeColor != null) {
+ bgColor = closeColor;
+ fgColor = Color.WHITE;
+ } else {
+ /* Light blue, via transparency to work well on any
background. In the grey
+ toolbar, it comes out similar to the hover background
used for toolbar buttons. */
+ bgColor = new Color(0, 132, 247, 49);
+ }
}
}
if (bgColor.getAlpha() > 0) {
```
Once Travis tests pass, this should be safe to merge (without squash, as the
3 commits are meant to be separate). I've been running this patch in my own
working IDE, and in my platform app, for two months now without issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
