matthiasblaesing commented on a change in pull request #3056:
URL: https://github.com/apache/netbeans/pull/3056#discussion_r671737410



##########
File path: 
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/StartTask.java
##########
@@ -691,6 +691,9 @@ private StartupArgs createProcessDescriptor() throws 
ProcessCreationException {
         // append other options from startup extenders, e.g. for profiling
         appendStartupExtenderParams(optList);
 
+        optList.add("--add-opens java.base/java.lang=ALL-UNNAMED");

Review comment:
       @nicolaken the question is: are the opens directives targeted at the 
glassfish process or at the netbeans process
   
   @pepness I would not be too surprised, if an application server uses 
reflection to change the JDK internals, so it is plausible from my perspective, 
that the module openes are required for the glassfish to work correctly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to