nicolaken commented on a change in pull request #3056:
URL: https://github.com/apache/netbeans/pull/3056#discussion_r672398259
##########
File path:
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/StartTask.java
##########
@@ -691,6 +691,9 @@ private StartupArgs createProcessDescriptor() throws
ProcessCreationException {
// append other options from startup extenders, e.g. for profiling
appendStartupExtenderParams(optList);
+ optList.add("--add-opens java.base/java.lang=ALL-UNNAMED");
Review comment:
This is not needed to run the Netbeans IDE, it's only needed to launch
Glassfish.
I have not tested, but because it spawn a new process, it should not inherit
the Netbeans IDE arguments, and thus not work.
##########
File path:
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/JavaSEPlatform.java
##########
@@ -44,11 +44,23 @@
v1_5,
/** JavaSE 1.6. */
v1_6,
- /** JavaEE 1.7. */
+ /** JavaSE 1.7. */
v1_7,
- /** JavaEE 1.8. */
- v1_8;
-
+ /** JavaSE 1.8. */
+ v1_8,
+ /** JavaSE 11. */
+ v11,
+ /** JavaSE 12. */
+ v12,
+ /** JavaSE 13. */
+ v13,
+ /** JavaSE 14. */
+ v14,
+ /** JavaSE 15. */
+ v15,
+ /** JavaSE 11. */
Review comment:
OMG, this commit that fixes a typo inserts a new typo!
```suggestion
/** JavaSE 16. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
