nicolaken commented on a change in pull request #3056:
URL: https://github.com/apache/netbeans/pull/3056#discussion_r680378826
##########
File path:
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/StartTask.java
##########
@@ -757,6 +761,20 @@ private void appendStartupExtenderParams(List<String>
optList) {
}
}
+ /**
+ * Appends options in order to open modules for java 9.0+
+ * @param optList
+ */
+ private void appendModuleOpensParams(List<String> optList) {
+ SpecificationVersion currentInstanceJavaVersion =
JavaUtils.serverInstancePlatform(instance).getSpecification().getVersion();
+ SpecificationVersion firstJavaVersionWithModules = new
SpecificationVersion("9");
+
+
if(currentInstanceJavaVersion.compareTo(firstJavaVersionWithModules)>=0){
+ optList.add("--add-opens java.base/java.lang=ALL-UNNAMED");
+ optList.add("--add-opens
java.naming/javax.naming.spi=ALL-UNNAMED");
Review comment:
Initially I saw the same thing, and tried running without this part. I
am using Liberica Jdk16, and downloaded and installed a fresh GF 6.1 directly
from Netbeans, without running Derby. I ran it and got explicit errors that
said that opening was needed. I did not investigate further for lack of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
