nicolaken commented on a change in pull request #3056:
URL: https://github.com/apache/netbeans/pull/3056#discussion_r680379595



##########
File path: 
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV6_1_0.xml
##########
@@ -23,9 +23,10 @@
     <tools lib="lib">
         <asadmin jar="client/appserver-cli.jar"/>
     </tools>
-    <java version="1.8">
-        <platform version="1.7"/>
-        <platform version="1.8"/>
+    <java version="11">
+        <platform version="1.8"/> 

Review comment:
       I saw conflicting info in different places. It basically says that Jdk11 
Is supported, but I do not see it mandatory. Also JakartaEE 10 will require 11, 
as of it was a new requirement. @juneau001 PR #2902 did not require 11. On the 
other hand I was not able to launch with 1.8 from Jdk16, it did not understand 
rmi opens from Glassfish. Maybe it needs to launch from a Netbeans running on 
1.8?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to