entlicher commented on a change in pull request #3180:
URL: https://github.com/apache/netbeans/pull/3180#discussion_r715659748
##########
File path:
ide/extexecution.base/src/org/netbeans/api/extexecution/base/ExplicitProcessParameters.java
##########
@@ -416,6 +497,12 @@ public Builder combine(@NullAllowed
ExplicitProcessParameters p) {
if (p.getArguments() != null) {
args(p.getArguments());
}
+ if (p.getWorkingDirectory() != null) {
+ workingDirectory(p.getWorkingDirectory());
+ }
+ if (!p.getEnvironmentVariables().isEmpty()) {
+ environmentVariables(p.getEnvironmentVariables());
Review comment:
You've inspired me by null values of env. variables. They are used to
remove an existing env. variable.
Javadoc improved to describe that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
