entlicher commented on a change in pull request #3180:
URL: https://github.com/apache/netbeans/pull/3180#discussion_r715664215
##########
File path:
java/maven/src/org/netbeans/modules/maven/runjar/LaunchArgPrereqsChecker.java
##########
@@ -122,6 +123,15 @@ public boolean checkRunConfig(RunConfig config,
ExecutionContext con) {
config.setProperty(MavenExecuteUtils.RUN_APP_PARAMS,
MavenExecuteUtils.joinParameters(appArgsValue));
}
+ File workingDirectory = injectParams.getWorkingDirectory();
+ if (workingDirectory != null) {
+ config.setProperty(MavenExecuteUtils.RUN_WORKDIR,
+ workingDirectory.getAbsolutePath());
+ }
+ Map<String, String> environmentVariables =
injectParams.getEnvironmentVariables();
+ for (Map.Entry<String, String> env : environmentVariables.entrySet()) {
+ config.setProperty("Env." + env.getKey(), env.getValue());
Review comment:
The config property can not have null value in Maven :-( I didn't want
to change that, this is why I've introduced `ENV_REMOVED` constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
