sdedic commented on a change in pull request #3206:
URL: https://github.com/apache/netbeans/pull/3206#discussion_r736753957



##########
File path: 
java/java.source.base/src/org/netbeans/modules/java/source/indexing/VanillaCompileWorker.java
##########
@@ -405,6 +405,7 @@ public void run() throws IOException {
                 JavaIndex.LOG.log(Level.FINEST, "VanillaCompileWorker was 
canceled in root: " + FileUtil.getFileDisplayName(context.getRoot()), ca);  
//NOI18N
             }
         } catch (Throwable t) {
+            t.printStackTrace();

Review comment:
       LOG instead of printStackTrace() ?

##########
File path: nbbuild/cluster.properties
##########
@@ -750,6 +749,8 @@ validation.nb.cluster.java=\
         java.hints,\
         java.kit
 
+#        java.source.nbjavac,\

Review comment:
       leftover ?

##########
File path: nb/updatecenters/extras/nbjavac/manifest.mf
##########
@@ -2,5 +2,5 @@ Manifest-Version: 1.0
 AutoUpdate-Show-In-Client: true
 OpenIDE-Module: org.netbeans.modules.nbjavac
 OpenIDE-Module-Localizing-Bundle: 
org/netbeans/modules/nbjavac/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.0
+OpenIDE-Module-Specification-Version: 17.35

Review comment:
       A big leap forward !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to