JaroslavTulach commented on a change in pull request #3352:
URL: https://github.com/apache/netbeans/pull/3352#discussion_r776169995
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
##########
@@ -124,3 +124,10 @@
harness/apisupport.harness/external/launcher-12.5-distribution.zip platform/o.n.
# only one is part of the product:
java/libs.javacapi/external/nb-javac-jdk-17.0.1-ga-api.jar
java/libs.nbjavacapi/external/nb-javac-jdk-17.0.1-ga-api.jar
java/libs.javacapi/external/nb-javac-jdk-17.0.1-ga.jar
java/libs.nbjavacapi/external/nb-javac-jdk-17.0.1-ga.jar
+
+# OCI SDK has frequently changing dependencies, so they are better kept
separate
Review comment:
Are these overlaps OK? I am inclined to believe they are. Having clashes
with gradle/maven distributions seems OK to me...
##########
File path: platform/o.apache.commons.lang3/build.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
+ <import file="../../nbbuild/templates/projectized.xml"/>
+ <target name="jar" depends="-define-FileCRC32Calculator">
+ <FileCRC32Calculator file="external/commons-lang3-3.8.1.jar"
property="o.apache.commons.lang3.crc32" />
+ <jar jarfile="${cluster}/${module.jar}">
Review comment:
I guess this follows a pattern copied from somewhere else, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
