matthiasblaesing commented on a change in pull request #3352:
URL: https://github.com/apache/netbeans/pull/3352#discussion_r782518123



##########
File path: enterprise/websvc.restlib/nbproject/project.xml
##########
@@ -57,33 +64,167 @@
                 <package>org.glassfish.jersey.client.http</package>
                 <package>org.glassfish.jersey.client.inject</package>
                 <package>org.glassfish.jersey.client.spi</package>
+                <package>javax.annotation</package>
+                <package>javax.annotation.security</package>
+                <package>javax.annotation.sql</package>
+                <package>javax.inject</package>
+                <package>javax.persistence</package>
+                <package>javax.persistence.criteria</package>
+                <package>javax.persistence.metamodel</package>
+                <package>javax.persistence.spi</package>
+                <package>javax.validation</package>
+                <package>javax.validation.bootstrap</package>
+                <package>javax.validation.constraints</package>
+                <package>javax.validation.constraintvalidation</package>
+                <package>javax.validation.executable</package>
+                <package>javax.validation.groups</package>
+                <package>javax.validation.metadata</package>
+                <package>javax.validation.spi</package>
+                <package>javax.validation.valueextraction</package>
+                <package>org.glassfish.hk2.api</package>
+                <package>org.glassfish.hk2.api.messaging</package>
+                <package>org.glassfish.hk2.extension</package>
+                <package>org.glassfish.hk2.internal</package>
+                <package>org.glassfish.hk2.osgiresourcelocator</package>
+                <package>org.glassfish.hk2.utilities</package>
+                <package>org.glassfish.hk2.utilities.binding</package>
+                <package>org.glassfish.hk2.utilities.cache</package>
+                <package>org.glassfish.hk2.utilities.cache.internal</package>
+                <package>org.glassfish.hk2.utilities.general</package>
+                <package>org.glassfish.hk2.utilities.general.internal</package>
+                <package>org.glassfish.hk2.utilities.reflection</package>
+                
<package>org.glassfish.hk2.utilities.reflection.internal</package>
+                <package>org.glassfish.jersey</package>
+                <package>org.glassfish.jersey.client.internal</package>
+                <package>org.glassfish.jersey.client.internal.inject</package>
+                
<package>org.glassfish.jersey.client.internal.jdkconnector</package>
+                <package>org.glassfish.jersey.client.internal.routing</package>
+                <package>org.glassfish.jersey.inject.hk2</package>
+                <package>org.glassfish.jersey.internal</package>
+                <package>org.glassfish.jersey.internal.config</package>
+                <package>org.glassfish.jersey.internal.guava</package>
+                <package>org.glassfish.jersey.internal.inject</package>
+                <package>org.glassfish.jersey.internal.jsr166</package>
+                <package>org.glassfish.jersey.internal.l10n</package>
+                <package>org.glassfish.jersey.internal.routing</package>
+                <package>org.glassfish.jersey.internal.sonar</package>
+                <package>org.glassfish.jersey.internal.spi</package>
+                <package>org.glassfish.jersey.internal.util</package>
+                
<package>org.glassfish.jersey.internal.util.collection</package>
+                <package>org.glassfish.jersey.logging</package>
+                <package>org.glassfish.jersey.message</package>
+                <package>org.glassfish.jersey.message.internal</package>
+                <package>org.glassfish.jersey.model</package>
+                <package>org.glassfish.jersey.model.internal</package>
+                <package>org.glassfish.jersey.model.internal.spi</package>
+                <package>org.glassfish.jersey.moxy.internal</package>
+                <package>org.glassfish.jersey.moxy.json</package>
+                <package>org.glassfish.jersey.moxy.json.internal</package>
+                <package>org.glassfish.jersey.moxy.xml</package>
+                <package>org.glassfish.jersey.process</package>
+                <package>org.glassfish.jersey.process.internal</package>
+                <package>org.glassfish.jersey.servlet</package>
+                <package>org.glassfish.jersey.servlet.internal</package>
+                <package>org.glassfish.jersey.servlet.internal.spi</package>
+                <package>org.glassfish.jersey.servlet.spi</package>
+                <package>org.glassfish.jersey.spi</package>
+                <package>org.glassfish.jersey.uri</package>
+                <package>org.glassfish.jersey.uri.internal</package>
+                <package>org.jvnet.hk2.annotations</package>
+                <package>org.jvnet.hk2.component</package>
+                <package>org.jvnet.hk2.external.generator</package>
+                <package>org.jvnet.hk2.external.runtime</package>
+                <package>org.jvnet.hk2.internal</package>
+                <package>org.osgi.dto</package>
+                <package>org.osgi.framework</package>
+                <package>org.osgi.framework.connect</package>
+                <package>org.osgi.framework.dto</package>
+                <package>org.osgi.framework.hooks.bundle</package>
+                <package>org.osgi.framework.hooks.resolver</package>
+                <package>org.osgi.framework.hooks.service</package>
+                <package>org.osgi.framework.hooks.weaving</package>
+                <package>org.osgi.framework.launch</package>
+                <package>org.osgi.framework.namespace</package>
+                <package>org.osgi.framework.startlevel</package>
+                <package>org.osgi.framework.startlevel.dto</package>
+                <package>org.osgi.framework.wiring</package>
+                <package>org.osgi.framework.wiring.dto</package>
+                <package>org.osgi.resource</package>
+                <package>org.osgi.resource.dto</package>
+                <package>org.osgi.service.condition</package>
+                <package>org.osgi.service.condpermadmin</package>
+                <package>org.osgi.service.log</package>
+                <package>org.osgi.service.log.admin</package>
+                <package>org.osgi.service.packageadmin</package>
+                <package>org.osgi.service.permissionadmin</package>
+                <package>org.osgi.service.resolver</package>
+                <package>org.osgi.service.startlevel</package>
+                <package>org.osgi.service.url</package>
+                <package>org.osgi.util.tracker</package>

Review comment:
       These exports look wrong to me. Shouldn't the module wrap 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to