sdedic commented on a change in pull request #3406:
URL: https://github.com/apache/netbeans/pull/3406#discussion_r778764278
##########
File path: java/java.lsp.server/vscode/src/testAdapter.ts
##########
@@ -71,7 +74,9 @@ export class NbTestAdapter {
}
}
}
- this.itemsToRun.forEach(item => this.set(item, 'skipped'));
+ if (this.started) {
Review comment:
originally this seemed awkward, but activates only if `testProgress`
sets it to true during one of the `await`s - right ?
##########
File path: java/java.lsp.server/vscode/src/testAdapter.ts
##########
@@ -71,7 +74,9 @@ export class NbTestAdapter {
}
}
}
- this.itemsToRun.forEach(item => this.set(item, 'skipped'));
+ if (this.started) {
Review comment:
Shouldn't be `cancellation` checked also in the 1st branch (line ~65)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
