dbalek commented on a change in pull request #3406:
URL: https://github.com/apache/netbeans/pull/3406#discussion_r778827412
##########
File path: java/java.lsp.server/vscode/src/testAdapter.ts
##########
@@ -71,7 +74,9 @@ export class NbTestAdapter {
}
}
}
- this.itemsToRun.forEach(item => this.set(item, 'skipped'));
+ if (this.started) {
Review comment:
Yes this change prevents tests to be marked as skipped in case they are
not even started (e.g. due to a compilation error).
Code modified to check `cancellation` in the first branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
