matthiasblaesing commented on a change in pull request #3433:
URL: https://github.com/apache/netbeans/pull/3433#discussion_r781405325
##########
File path:
dlight/dlight.remote.ui/src/org/netbeans/modules/remote/api/ui/FileChooserUIImpl.java
##########
@@ -3509,29 +3504,6 @@ private void enableAllButCancel(boolean enable) {
private void changeDirectory(File dir) {
JFileChooser fc = getFileChooser();
- // Traverse shortcuts on Windows
- if (dir != null && FilePane.usesShellFolder(fc)) {
Review comment:
What happens on windows with the removal of this? Will the user have a
bad experience or will it still work?
##########
File path:
cnd/cnd.toolchain.ui/src/org/netbeans/modules/cnd/toolchain/ui/compiler/CodeAssistancePanelController.java
##########
@@ -26,12 +26,14 @@
import org.openide.util.HelpCtx;
import org.openide.util.Lookup;
[email protected](
- id=CndUIConstants.TOOLS_OPTIONS_CND_CODE_ASSISTANCE_ID,
- location=CndUIConstants.TOOLS_OPTIONS_CND_CATEGORY_ID,
- displayName="#TAB_CodeAssistanceTab", // NOI18N
- position=300
-)
+// Overriden with a manually generated layer.xml file.
+// See https://issues.apache.org/jira/browse/NETBEANS-6372
+//@OptionsPanelController.SubRegistration(
+// id=CndUIConstants.TOOLS_OPTIONS_CND_CODE_ASSISTANCE_ID,
+// location=CndUIConstants.TOOLS_OPTIONS_CND_CATEGORY_ID,
+// displayName="#TAB_CodeAssistanceTab", // NOI18N
+// position=300
+//)
Review comment:
I suggest to remove the commented out sections and add a comment in the
`layer.xml` that the definition was moved to the layer file because the
`weight` attribute needs to be defined.
##########
File path:
cnd/cnd.toolchain.ui/src/org/netbeans/modules/cnd/toolchain/ui/options/ToolsPanelController.java
##########
@@ -26,12 +26,14 @@
import org.openide.util.HelpCtx;
import org.openide.util.Lookup;
[email protected](
- id=CndUIConstants.TOOLS_OPTIONS_CND_TOOLS_ID,
- location=CndUIConstants.TOOLS_OPTIONS_CND_CATEGORY_ID,
- displayName="#TAB_ToolsTab", // NOI18N
- position=100
-)
+// Overriden with a manually generated layer.xml file.
+// See https://issues.apache.org/jira/browse/NETBEANS-6372
+//@OptionsPanelController.SubRegistration(
+// id=CndUIConstants.TOOLS_OPTIONS_CND_TOOLS_ID,
+// location=CndUIConstants.TOOLS_OPTIONS_CND_CATEGORY_ID,
+// displayName="#TAB_ToolsTab", // NOI18N
+// position=100
+//)
Review comment:
See comment in `CodeAssistancePanelController.java`
##########
File path:
cnd/cnd.toolchain.ui/src/org/netbeans/modules/cnd/toolchain/ui/options/package-info.java
##########
@@ -17,13 +17,15 @@
* under the License.
*/
[email protected](
- id=CndUIConstants.TOOLS_OPTIONS_CND_CATEGORY_ID,
- categoryName="#CndOptionsCategory_Name", // NOI18N
-// title="#CndOptions_Title"
- iconBase="org/netbeans/modules/cnd/toolchain/ui/options/cnd_32.png", //
NOI18N
- position=700
-)
+// Overriden with a manually generated layer.xml file.
+// See https://issues.apache.org/jira/browse/NETBEANS-6372
+//@OptionsPanelController.ContainerRegistration(
+// id=CndUIConstants.TOOLS_OPTIONS_CND_CATEGORY_ID,
+// categoryName="#CndOptionsCategory_Name", // NOI18N
+//// title="#CndOptions_Title"
+// iconBase="org/netbeans/modules/cnd/toolchain/ui/options/cnd_32.png", //
NOI18N
+// position=700
+//)
Review comment:
See comment in `CodeAssistancePanelController.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
