vieiro commented on a change in pull request #3433:
URL: https://github.com/apache/netbeans/pull/3433#discussion_r781775176
##########
File path:
dlight/dlight.remote.ui/src/org/netbeans/modules/remote/api/ui/FileChooserUIImpl.java
##########
@@ -3509,29 +3504,6 @@ private void enableAllButCancel(boolean enable) {
private void changeDirectory(File dir) {
JFileChooser fc = getFileChooser();
- // Traverse shortcuts on Windows
- if (dir != null && FilePane.usesShellFolder(fc)) {
Review comment:
D'oh.
It seems this very exact piece of NetBeans code (that we've deleted) ended
up landing in the OpenJDK implementation of "BasicFileChooserUI.java" here
https://github.com/openjdk/jdk/blob/0a65e8b282fd41e57108422fbd140527d9697efd/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java#L1363
So, AFAIU, there's no real need to implement it here (as we're extending
JDK's BasicFileChooserUI). In fact I do prefer this code being mantained by the
JDK Team, and not here in NetBeans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
