neilcsmith-net commented on pull request #3454: URL: https://github.com/apache/netbeans/pull/3454#issuecomment-1013077775
I'm -0.5 on this. This is almost what I tried too, but I still prefer what we had before. Although it does fix the critical issue with user actions. Having actions disabled elsewhere in the UI when there are no goals makes sense. Just less sure here. I'm not sure what the purpose of the manual `Disable` button is exactly? Certainly having to click the button labelled with `Remove` in order to re-enable an action seems counter-intuitive. Can this not be controlled by the existence of goals for now, rather than disabling that input field entirely? The various labels turning bold (`Execute Goals`, `Activate Profiles`, etc.) when the disabled action is selected makes everything bounce around, although I think that was a bug before with custom actions. Aside : I set up a Micronaut project to test this, but the dev mode profile isn't showing up in a current build vs 12.6?? Same without this PR, so not related, but was trying to see how this interacts with that. That mvnw isn't executable also breaks the Micronaut wizard (which I should probably look at!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
