sdedic edited a comment on pull request #3454:
URL: https://github.com/apache/netbeans/pull/3454#issuecomment-1013088340


   > Having actions disabled elsewhere in the UI when there are no goals makes 
sense. Just less sure here. I'm not sure what the purpose of the manual 
`Disable` button is exactly? 
   
   Implementation-wise it clears the goals. I am pretty sure that if the 
'disable' would be just implied by missing goals, other 1/2 of userbase would 
find that approach counter-intuitive: "why a 'DIsable" action is not there and 
I have to remember how to do it ?"
   
   There's also an option to remove the 'disable' capability entirely - it was 
originally introduced mainly as a way to override possible plugin 
contributions: Micronaut plugin disables Debug (for good reasons in dev- mode), 
which might break user's workflow; so if the user understands the consequences, 
he/she can enable the action now.
   
   > Certainly having to click the button labelled with `Remove` in order to 
re-enable an action seems counter-intuitive. Can this not be controlled by the 
existence of goals for now, rather than disabling that input field entirely?
   
   For now, since missing property that would explicitly control disabling, the 
action cannot be just re-enabled; important property (goals) is cleared and 
can't be restored. The `Restore` button does that. There's 
[NETBEANS-6387](https://issues.apache.org/jira/browse/NETBEANS-6387) that 
should addresses the situation better - at the expense of API/persistence 
format changes.
   It's just I don't want to make the persistence changes 1 business day before 
branch point :)
   
   > The various labels turning bold (`Execute Goals`, `Activate Profiles`, 
etc.) when the disabled action is selected makes everything bounce around, 
although I think that was a bug before with custom actions.
   > 
   Yes, this had existed even before; fill an additional bug, it doesn't have 
anything common with functionality discussed here, it's pure UI/design related.
   
   > Aside : I set up a Micronaut project to test this, but the dev mode 
profile isn't showing up in a current build vs 12.6?? Same without this PR, so 
not related, but was trying to see how this interacts with that. That mvnw 
isn't executable also breaks the Micronaut wizard (which I should probably look 
at!)
   
   Please make sure the Micronaut module is enabled; it is (by default) not 
loaded. I don't think we have auto-enablement of modules based on Maven POM 
plugin declarations ... but we could have ! Please file an issue.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to