matthiasblaesing commented on pull request #3433:
URL: https://github.com/apache/netbeans/pull/3433#issuecomment-1013483446
Looks good to me. I first thought, that we need to add "add-opens" clauses
to `netbeans.conf`, but it turns out, that we already have them all :-)
However I failed to build with JDK 11 with this - the problem is in
`cnd.dwarfdump`. There is target hard coded in the `javac.compilerargs`,
instead of using the `javac.target` property. This breaks hard, when the
`javac` tasks gets `target` and `release`.
I suggest this fix (yes I also bumped it this JDK 1.8 as baseline):
```diff
diff --git a/cnd/cnd.dwarfdump/nbproject/project.properties
b/cnd/cnd.dwarfdump/nbproject/project.properties
index 474f85f56b1b..9209f03ea426 100644
--- a/cnd/cnd.dwarfdump/nbproject/project.properties
+++ b/cnd/cnd.dwarfdump/nbproject/project.properties
@@ -14,6 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-javac.compilerargs=-Xlint -Xlint:-serial -target 1.5
-javac.source=1.5
+javac.compilerargs=-Xlint -Xlint:-serial
+javac.source=1.8
spec.version.base=1.37.9
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
