vieiro commented on pull request #3506: URL: https://github.com/apache/netbeans/pull/3506#issuecomment-1022172629
Hi @neilcsmith-net . I can't really review this one, but a quick look reasonable. Two questions: - A) Are we setting the background color in that notice? It seems to me is reducing contrast. Can't tell how this looks in a dark mode. - B) Is this expected to solve NETBEANS-6401 ? If so I'm missing setting an executable bit in "mvnw" after unzipping, right? Thanks, Antonio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
