mbien commented on pull request #3506: URL: https://github.com/apache/netbeans/pull/3506#issuecomment-1022958614
I think it looks really nice + this PR fixes an important issue. I suppose it could be make more DRY by updating the notification service and letting it use it like Neil suggested but I feel this would have low priority when taken in context. Updating the notification support would also require more testing since its used everywhere. Still +1 from me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
