matthiasblaesing commented on pull request #3713: URL: https://github.com/apache/netbeans/pull/3713#issuecomment-1060039827
I pushed a different implementation a few minutes ago. Sorry for the complete replacement, but the differences would have touch many files anyway: - @vieiro rightly pointed out, that in the case, that if Pagent is used, the SSHAgent instatiation becomes useless. The updated implementation prefers the SSHAgent. If that is present, it is directly returned. That might change the situation for windows users, when both a Pagent _and_ an SSHAgent is present. However in this case I'd expect the SSHAgent to act as a proxy to the Pagent. So in sane setups nothing should change. - the dependencies for the OSGI module were also declared on the JSch wrapper module. It is unclear whether or not this is necessary, but it can't hurt. - Specification versions were bumped for junixsocket, libs.git and php.project - The removal of the libs.jsch.agentproxy module was reverted and instead the factory method for the AgentConnector was updated to the new JSch API (Release and specification version were bumped accordingly) An updated test build can be found here: http://doppel-helix.eu/NetBeans-dev-dev-5573b9c9e8794ba43374347606509a5a4206a00a-release.zip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
