matthiasblaesing commented on pull request #3713: URL: https://github.com/apache/netbeans/pull/3713#issuecomment-1060244566
> > @ebresie wrong question. The right question is: What would you test? Jsch is basicly just the original library with OSGI headers (specific for netbeans). Same is junixsocket. The rest are integrations that used now broken code paths. > > Why the authentication failed given good user and password I'm not clear of but... The authentication failed using an SSH key, that was generated using a new enough `ssh-keygen` version. The reason is, that that the format changed and also new algorithms were introduced. Both not supported by the JSch version we bundled. JSch in its original version was not updated and a fork was created: https://github.com/mwiede/jsch, to which this PR switches. > so unit test the "now broken code path". Test (with existing or new test) a git fetch via ssh connection type that fails to authentication (and triggers the behavior described) to reproduces the problem before the fix and works after the fix. Thank you - I know what a test is and how it works. This integration test (it tests interdependent behaviour) would need to setup an SSH server, a git repository and the right keys and then check what you describe. But this would most probably not have caught this issue, as I would have used pre generated keys and this would continue to work. Even freshly generated keys need to have the algorithm selected, which would again yield compatible keys. What is more, you are talking about serious work here, the external SSH server must work on all architectures tests are run and needs to be reliable. We have enough such complex tests, that only cause headaches and lead to people to discarding problems reported by them. Feel free to create a test, I won't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
