jlahoda commented on pull request #3715: URL: https://github.com/apache/netbeans/pull/3715#issuecomment-1078055235
Well, I've never said this does not fix something. I just said it also will likely break something (and I have one more below). Anyway, if all you want to fix is [NETBEANS-5829](https://issues.apache.org/jira/browse/NETBEANS-5829) and make sure the test passes, I suspect simply not doing the downgrade would do the same, with hopefully a smaller fallout. If there's some other usecase you intend to fix, you should have a test for that as well, otherwise it may regress at any time. There may be another problem I didn't realize before - when the source level selected is newer than the highest source level supported by the given compiler, it seems it may crash with an exception, possibly rendering the IDE useless for some users (me possibly included, depending on the circumstances). Anyway - you've asked for a review/opinion, I provided one. I can't stop you from doing this, but it is not clear to me who will be responsible for the fallout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
