jtulach commented on a change in pull request #3715:
URL: https://github.com/apache/netbeans/pull/3715#discussion_r836051482
##########
File path:
java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java
##########
@@ -1078,6 +1086,23 @@ private static JavacTaskImpl createJavacTask(
return task;
}
+ private static String useRelease(final String requestedSource,
com.sun.tools.javac.code.Source validatedSourceLevel) {
+ if (requestedSource == null || validatedSourceLevel == null) {
+ return null;
+ }
+ com.sun.tools.javac.code.Source sourceLevel =
com.sun.tools.javac.code.Source.lookup(requestedSource);
+ if (sourceLevel == null) {
Review comment:
These are the non-fatal errors I see on console:
```
java.lang.NullPointerException
org.netbeans.modules.java.editor.base.semantic.UnusedDetector.isUnusedInPkg(UnusedDetector.java:322)
org.netbeans.modules.java.editor.base.semantic.UnusedDetector.findUnused(UnusedDetector.java:138)
org.netbeans.modules.java.editor.base.semantic.SemanticHighlighterBase.process(SemanticHighlighterBase.java:185)
```
```
java.lang.NullPointerException
org.netbeans.modules.java.source.indexing.VanillaCompileWorker$3.visitVariable(VanillaCompileWorker.java:585)
org.netbeans.modules.java.source.indexing.VanillaCompileWorker$3.visitVariable(VanillaCompileWorker.java:535)
com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:1045)
com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86)
org.netbeans.modules.java.source.indexing.VanillaCompileWorker$3.scan(VanillaCompileWorker.java:886)
```
```
WARNING [org.netbeans.modules.java.source.usages.BinaryAnalyser]: Invalid
class file format:
file:/home/devel/NetBeansProjects/netbeans/nbbuild/netbeans/java/modules/ext/fakeJdkClasses.zip!/java/lang/AutoCloseable.class
INFO [org.netbeans.modules.java.source.usages.BinaryAnalyser]: Class File
Exception Details
java.io.EOFException
at
java.base/java.io.DataInputStream.readInt(DataInputStream.java:397)
at
org.netbeans.modules.classfile.ClassFile.loadClassHeader(ClassFile.java:183)
at org.netbeans.modules.classfile.ClassFile.load(ClassFile.java:168)
Caused: org.netbeans.modules.classfile.InvalidClassFormatException
at org.netbeans.modules.classfile.ClassFile.load(ClassFile.java:174)
at
org.netbeans.modules.classfile.ClassFile.<init>(ClassFile.java:126)
at org.netbeans.modules.classfile.ClassFile.<init>(ClassFile.java:73)
at
org.netbeans.modules.java.source.usages.BinaryAnalyser.analyse(BinaryAnalyser.java:670)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
