mbien commented on a change in pull request #3894:
URL: https://github.com/apache/netbeans/pull/3894#discussion_r838998547
##########
File path:
platform/openide.util/test/unit/src/org/openide/util/BaseUtilitiesTest.java
##########
@@ -38,65 +39,65 @@ public BaseUtilitiesTest(String name) {
@Override
protected void setUp() throws Exception {
super.setUp();
- BaseUtilities.resetOperatingSystem ();
+ BaseUtilities.resetOperatingSystem();
originalOsName = System.getProperty("os.name");
}
-
+
@Override
protected void tearDown() throws Exception {
System.setProperty("os.name", originalOsName);
super.tearDown();
}
- public void testGetOperatingSystemWinNT () {
- System.setProperty ("os.name", "Windows NT");
+ public void testGetOperatingSystemWinNT() {
+ System.setProperty("os.name", "Windows NT");
//assertEquals ("System.getProperty (os.name) returns Windows NT",
"Windows NT", System.getProperty ("os.name"));
- assertEquals ("Windows NT recognized as OS_WINNT",
BaseUtilities.OS_WINNT, BaseUtilities.getOperatingSystem ());
+ assertEquals("Windows NT recognized as OS_WINNT",
BaseUtilities.OS_WINNT, BaseUtilities.getOperatingSystem());
Review comment:
there is a little trick you can do if you really really want to sneak
reformats into a PR which is not related: you keep them in a separate commit
and mention it in the PR text (but don't overdo that). So reviewers can
concentrate on the non-stylistic changes, but still glance over the formatting
commit and look at it separately from the actual issue. Reducing noise is
always helpful. (it also makes it much easier to revert if the reviewers don't
want the formatting changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
