mbien commented on a change in pull request #3894:
URL: https://github.com/apache/netbeans/pull/3894#discussion_r839012669



##########
File path: 
platform/openide.util/test/unit/src/org/openide/util/BaseUtilitiesTest.java
##########
@@ -126,8 +206,10 @@ public void testFileURI() throws Exception {
             assertEquals(new File("/some/path"), BaseUtilities.toFile(new 
URI("file:///some/path")));
             assertEquals(new File("/some/path"), BaseUtilities.toFile(new 
URI("file:/some/path/")));
         }
+        //the following code seems not to have sense at all

Review comment:
       i think it wants to test the method `BaseUtilities.toURI()` against 
expected results taken by using URI directly. It doesn't look too bad in my 
eyes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to