matthiasblaesing commented on code in PR #4284:
URL: https://github.com/apache/netbeans/pull/4284#discussion_r907546666
##########
nbbuild/templates/projectized.xml:
##########
@@ -290,7 +290,7 @@
<target name="test-lib-init"
depends="-init-bootclasspath-prepend,init,-build-libs.junit4">
<path id="test.unit.lib.cp"/>
<property name="test.jms.flags" value=""/>
- <property name="test.run.args" value="-ea -Xmx700m
${metabuild.jms-flags.jvm} ${test.jms.flags} -XX:+IgnoreUnrecognizedVMOptions"/>
+ <property name="test.run.args" value="-ea -Xms1200m -Xmx1200m
-XX:+UseParallelGC ${metabuild.jms-flags.jvm} ${test.jms.flags}
-XX:+IgnoreUnrecognizedVMOptions"/>
Review Comment:
My point is: If there is no measurement of the performance improvement, all
the activation of ParallelGC brings us is noise. I'm no GC expert and I have
yet to see a situation where I have to become one, most cases I saw in real
life were fixed by removing "optimizations" others have added, so I tend to
prefer the defaults until proven wrong.
But then this is not important enough to waste to much time over, so if you
think it helps, lets keep it, until the first JDK without ParallelGC surfaces.
##########
ide/parsing.indexing/src/org/netbeans/modules/parsing/impl/indexing/PathRegistry.java:
##########
@@ -68,7 +68,7 @@
public final class PathRegistry implements Runnable {
private static final boolean FIRE_UNKNOWN_ALWAYS = false;
- /*test*/ static final int FIRER_EVT_COLLAPSE_WINDOW = 500;
+ /*test*/ static final int FIRER_EVT_COLLAPSE_WINDOW =
Integer.getInteger(PathRegistry.class.getName()+".FIRER_EVT_COLLAPSE_WINDOW",
500);
Review Comment:
Just an idea: it might be good to add a comment here, that this is a system
property to help tests, so that noone ever can claim this is some supported
system property we have to retain even if the unittests run fast without
twiddling with ti.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
