mbien commented on code in PR #4284:
URL: https://github.com/apache/netbeans/pull/4284#discussion_r907709558
##########
nbbuild/templates/projectized.xml:
##########
@@ -290,7 +290,7 @@
<target name="test-lib-init"
depends="-init-bootclasspath-prepend,init,-build-libs.junit4">
<path id="test.unit.lib.cp"/>
<property name="test.jms.flags" value=""/>
- <property name="test.run.args" value="-ea -Xmx700m
${metabuild.jms-flags.jvm} ${test.jms.flags} -XX:+IgnoreUnrecognizedVMOptions"/>
+ <property name="test.run.args" value="-ea -Xms1200m -Xmx1200m
-XX:+UseParallelGC ${metabuild.jms-flags.jvm} ${test.jms.flags}
-XX:+IgnoreUnrecognizedVMOptions"/>
Review Comment:
we can measure. We can compare average (non-php) travis runs from after this
PR to before if there are any changes. What I mean is that it is annoying to
test it locally since we have so many hours of tests.
Conceptionally, ParallelGC is the right GC for this use case since it is the
only "throughput GC" there is. Setting a GC has also the benefit of getting
predictable results. Tests on 8 would use ParallelGC but anything beyond 8
would likely use G1GC. I say likely since there is also ergonomics code in the
JVM, If it does not detect enough cores or memory it might pick something else
- this is not specified and could change from version to version, how well the
container detection works etc. So setting a GC for tests gives us the opposite
of noise IMO.
Serial and Parallel GCs fill an important niche and are still getting new
features. I use ParallelGC for example for the maven daemon too. It has less
memory and less computational overhead compared to the concurrent GCs which is
exactly what you want for worker processes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
