BradWalker commented on code in PR #4297:
URL: https://github.com/apache/netbeans/pull/4297#discussion_r910539108


##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/ExamineManifest.java:
##########
@@ -51,7 +51,7 @@ public class ExamineManifest  {
     private String locBundle;
     private boolean publicPackages;
     private boolean populateDependencies = false;
-    private List dependencyTokens = Collections.emptyList();
+    private List<String> dependencyTokens = Collections.<String>emptyList();

Review Comment:
   Hey @mbien , I thought I had tried doing just that.. But, couldn't 
remember.. When I do this work, I try to go as fast as possible, so sometimes I 
do forget.
   
   But, here is the error that I get.. So I guess it's not possible.
   
   ```
      [depend] Deleted 2 out of date files in 0 seconds
    [nb-javac] Compiling 2 source files to 
/home/bwalker/src/netbeans/apisupport/maven.apisupport/build/classes
      [repeat] 
/home/bwalker/src/netbeans/apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/ExamineManifest.java:54:
 error: illegal start of type
      [repeat]     private List<String> dependencyTokens = 
Collections.<>emptyList();
      [repeat]                                                          ^
      [repeat] 1 error
     [nbmerge] Failed to build target: all-maven.apisupport
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to