mbien commented on code in PR #4297:
URL: https://github.com/apache/netbeans/pull/4297#discussion_r910543314
##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/ExamineManifest.java:
##########
@@ -51,7 +51,7 @@ public class ExamineManifest {
private String locBundle;
private boolean publicPackages;
private boolean populateDependencies = false;
- private List dependencyTokens = Collections.emptyList();
+ private List<String> dependencyTokens = Collections.<String>emptyList();
Review Comment:
no you don't understand. you don't have to specify the generic type at all.
`private List<String> dependencyTokens = Collections.emptyList();`
since you already merged, please clean it up in follow up PRs because
specifying generic types for methods is only needed for edge cases, like in
lambdas, but not for simple declarations like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
