mbien commented on code in PR #4431:
URL: https://github.com/apache/netbeans/pull/4431#discussion_r928718360
##########
.github/workflows/main.yml:
##########
@@ -127,12 +131,55 @@ jobs:
path:
/home/runner/work/netbeans/netbeans/nbbuild/build/test/commit-validation/results/
retention-days: 1
+
+ sig-test:
+ name: Verify sigs/libs/licenses/RAT on Linux/JDK ${{ matrix.java }}
+ needs: base-build
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar --zstd -xf build.tar.zst
+
+ - name: Verify libs and licenses
+ run: ant $OPTS -quiet verify-libs-and-licenses
-Dverify-libs-and-licenses.haltonfailure=true
+
+ - name: Check line endings and verify RAT report
+ if: success() || failure()
+ run: |
+ nbbuild/travis/check-line-endings.sh
+ ant -quiet build-source-config
+ mkdir scratch && cd scratch
+ unzip -qq ../nbbuild/build/release-src*
+ ant $OPTS -quiet rat -Drat-report.haltonfailure=true
+
+ - name: Run check-sigtests-release
+ if: success() || failure()
+ run: ant $OPTS -quiet check-sigtests-release -Dfail.on.error=true
+
+ - name: Run gen-sigtests-release
+ if: success() || failure()
+ run: ant $OPTS gen-sigtests-release
Review Comment:
@neilcsmith-net I tried to merge some of the "paperwork jobs" into one job,
but RAT fails.
```
/home/runner/work/netbeans/netbeans/scratch/nbbuild/build.xml:2195: Failed
Rat test(s):
Unapproved license in 4 file(s)
extide/gradle/netbeans-gradle-tooling/.gradle/7.4/gc.properties
extide/gradle/netbeans-gradle-tooling/.gradle/buildOutputCleanup/cache.properties
extide/gradle/netbeans-gradle-tooling/.gradle/vcs-1/gc.properties
extide/gradle/netbeans-gradle-tooling/.gradle/7.4/dependencies-accessors/gc.properties
Unapproved license in 1 file(s)
profiler/lib.profiler/release/BUILDINFO.txt
Unapproved license in 1 file(s)
```
I don't know much about RAT. Does it have to be run on a repo which is not
built?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
