mbien commented on code in PR #4431:
URL: https://github.com/apache/netbeans/pull/4431#discussion_r929196584
##########
.github/workflows/main.yml:
##########
@@ -335,7 +907,9 @@ jobs:
- name: Test PHP Doctrine2
run: ant $OPTS -f php/php.doctrine2 test
+ # todo: longest step -> needs 2 tiers, with tier 2 conditional
- name: Test PHP Editor
+ if: contains(github.event.pull_request.labels.*.name, 'PHP') ||
github.event_name != 'pull_request'
run: ant $OPTS -f php/php.editor test
Review Comment:
@neilcsmith-net this seems to work. The step runs only if the PR has the PHP
label on it. If this isn't a PR, it will run too (e.g merge to master). This
alone would cut down 2x40mins per sync and the fast steps would still run.
Ideally someone would split php.editor into two tiers some time in future.
Requires to label the PRs correctly. Other labels could follow if more
categories with long running jobs are found.
This is somewhat similar to how the OpenJDK project works, its just more
sophisticated there (a bot manages everything and sets things).
We could also add a full-test label, so that if someone isn't sure or
changes something in the platform or API, it would just turn everything on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
