lkishalmi commented on code in PR #4625:
URL: https://github.com/apache/netbeans/pull/4625#discussion_r968948709
##########
ide/languages.yaml/src/org/netbeans/modules/languages/yaml/YamlLanguage.java:
##########
@@ -155,12 +167,72 @@ public InstantRenamer getInstantRenamer() {
return null;
}
+ public static final Language<YamlTokenId> language =
Review Comment:
Well, despite it is written all lowercase, the `language` is a constant. I
see nothing wrong using public class constants without a wrapping static
method. (I'm with the remove the bloat folks) That static method was required
for the `MimeRegistration`, which after all is not required.
Ideally it could be a private final field, though it is being used one time
in the Parser. and about 10 times in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
