matthiasblaesing commented on code in PR #4625:
URL: https://github.com/apache/netbeans/pull/4625#discussion_r972278482
##########
ide/languages.yaml/src/org/netbeans/modules/languages/yaml/YamlLanguage.java:
##########
@@ -155,12 +167,72 @@ public InstantRenamer getInstantRenamer() {
return null;
}
+ public static final Language<YamlTokenId> language =
Review Comment:
As said - for an API using a constant removes the possibility to create
Adapter on demand as initialization will happen at class load time.
As said from my POV this is a code smell as it exposes internals while
gaining little.
For the current change it is ok, as it is hidden in the module and thus free
to change at any time, but should this ever become API this would have to go.
So ignore this now, I made my point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
